Add swap file checking in verify_no_swap_on_osdisk

[lubaihua33]

No description provided.

[Copilot]

Pull Request Overview

Adds swap file detection to the existing OS-disk swap verification and refactors the swap tool to return structured data.

• Extended verify_no_swap_on_osdisk to detect both swap partitions and swap files, with updated logging and error messages.
• Introduced a new SwapPartition dataclass and updated SwapOn.get_swap_partitions to return List[SwapPartition] instead of List[str].
• Enhanced the swap tool to use Df for resolving swap-file partitions and improved code organization.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
microsoft/testsuites/core/azure_image_standard.py	Updated test metadata, documentation, logging, and exception messages to include swap files.
lisa/tools/swap.py	Added SwapPartition dataclass, updated imports, and refactored get_swap_partitions logic.

Comments suppressed due to low confidence (3)

lisa/tools/swap.py:19

• Add a docstring to the SwapPartition dataclass explaining its fields (filename, type, partition) to improve clarity.

@dataclass

lisa/tools/swap.py:78

• Changing the return type from List[str] to List[SwapPartition] is a breaking API change—update the method docstring and communicate this change to callers or provide a migration path.

    def get_swap_partitions(self) -> List[SwapPartition]:

microsoft/testsuites/core/azure_image_standard.py:1647

• The error message refers to 'Swap Partition on OS Disk'—update it to consistently mention swap files (e.g. 'Swap partition or file on OS Disk') to match the test description.

                            f"Swap partition/file '{swap_part.filename}' is found on "

[LiliDeng]

@squirrelsc LGTM.

[squirrelsc]

Pull Request Overview

Adds swap file detection to the existing OS-disk swap verification and refactors the swap tool to return structured data.

• Extended verify_no_swap_on_osdisk to detect both swap partitions and swap files, with updated logging and error messages.
• Introduced a new SwapPartition dataclass and updated SwapOn.get_swap_partitions to return List[SwapPartition] instead of List[str].
• Enhanced the swap tool to use Df for resolving swap-file partitions and improved code organization.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
microsoft/testsuites/core/azure_image_standard.py Updated test metadata, documentation, logging, and exception messages to include swap files.
lisa/tools/swap.py Added SwapPartition dataclass, updated imports, and refactored get_swap_partitions logic.
Comments suppressed due to low confidence (3)
lisa/tools/swap.py:19

• Add a docstring to the SwapPartition dataclass explaining its fields (filename, type, partition) to improve clarity.

@dataclass

lisa/tools/swap.py:78

• Changing the return type from List[str] to List[SwapPartition] is a breaking API change—update the method docstring and communicate this change to callers or provide a migration path.

    def get_swap_partitions(self) -> List[SwapPartition]:

microsoft/testsuites/core/azure_image_standard.py:1647

• The error message refers to 'Swap Partition on OS Disk'—update it to consistently mention swap files (e.g. 'Swap partition or file on OS Disk') to match the test description.

                            f"Swap partition/file '{swap_part.filename}' is found on "

Please provide test suggestions.