Skip to content

Ineffective color contrast on radio buttons in the Sound Effect editor #10563

Open
@glastonbridge

Description

@glastonbridge

Describe the bug

Building pxt and pxt-microbit on master, the Makecode Sound Effect editor waveform radio buttons do not contrast sufficiently to show which is selected (see screenshots below). Raising in pxt because this appears to be where the theme color is defined for this particular element.

To Reproduce

  1. Create a Makecode project
  2. Add a sound effect block
  3. Click on the sound effect block to open the editor
  4. Choose from the different waveform options

Expected behavior

I would expect it to be more obvious which of the waveform buttons is currently selected. This is a problem for visual accessibility. Previous versions, including the one at https://makecode.microbit.org, have had a clearer distinction between the selected and unselected buttons.

Screenshots

This is how it appears in master currently (this issue):

Image

And this is how it used to appear (better contrast):

Image
  • OS: Mac OS
  • Browser: chrome
  • Version: 136.0.7103.48

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions