.Net: Add ONNX ChatClient Extensions + UT #12477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
westey-m
reviewed
Jun 16, 2025
dotnet/src/Connectors/Connectors.Onnx/OnnxServiceCollectionExtensions.DependencyInjection.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Jun 16, 2025
dotnet/src/Connectors/Connectors.Onnx/OnnxServiceCollectionExtensions.DependencyInjection.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
Jun 16, 2025
markwallace-microsoft
approved these changes
Jun 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
# Add IChatClient Extensions for ONNX Connector ## Summary This PR implements missing AddOnnxChatClient extension methods for the ONNX Connector, providing support for the new IChatClient interface alongside the existing IChatCompletionService extensions. ## Changes Made - New Extension Methods - IServiceCollection Extensions: Added AddOnnxRuntimeGenAIChatClient method in a dedicated ServiceCollectionExtensions.DependencyInjection.cs file following the same pattern as other connectors like OpenAI - IKernelBuilder Extensions: Added AddOnnxRuntimeGenAIChatClient method in OnnxKernelBuilderExtensions.ChatClient.cs for seamless kernel configuration
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
github-project-automation
bot
moved this from Sprint: In Review
to Sprint: Done
in Semantic Kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IChatClient Extensions for ONNX Connector
Summary
This PR implements missing AddOnnxChatClient extension methods for the ONNX Connector, providing support for the new IChatClient interface alongside the existing IChatCompletionService extensions.
Changes Made