Skip to content

Commit dfcc85c

Browse files
authored
Update HTML to remove some HTML5 warnings (#576)
1 parent c761b1e commit dfcc85c

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

workbench-app/src/components/App/DialogControl.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export const DialogControl: React.FC<DialogControlContent> = (props) => {
5858
const classes = useClasses();
5959

6060
return (
61-
<Dialog open={open} defaultOpen={defaultOpen} onOpenChange={onOpenChange}>
61+
<Dialog open={open} defaultOpen={defaultOpen} onOpenChange={onOpenChange} inertTrapFocus={true}>
6262
<DialogTrigger disableButtonEnhancement>{trigger}</DialogTrigger>
6363
<DialogSurface className={classNames?.dialogSurface}>
6464
<DialogBody>

workbench-app/src/routes/ShareRedeem.tsx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ export const ShareRedeem: React.FC = () => {
165165
onClick: () => void;
166166
}) => {
167167
return (
168-
<DialogTrigger disableButtonEnhancement action="open">
168+
<DialogTrigger disableButtonEnhancement action="open" key={options.label}>
169169
<Button
170170
style={{ width: 'max-content' }}
171171
appearance={options?.appearance ?? 'primary'}
@@ -255,11 +255,11 @@ export const ShareRedeem: React.FC = () => {
255255
return renderAppView({
256256
dialogTitle: 'Share is no longer redeemable',
257257
dialogContent: (
258-
<p>
258+
<div>
259259
The share has already been redeemed or has expired.
260260
{shareDetails}
261261
If you believe this is an error, please contact the person who shared the conversation with you.
262-
</p>
262+
</div>
263263
),
264264
});
265265

@@ -269,13 +269,13 @@ export const ShareRedeem: React.FC = () => {
269269
dialogTitle: inviteTitle,
270270
dialogContent: (
271271
<>
272-
<p>
272+
<div>
273273
You have been <em>invited to participate</em> in a conversation: By joining, you will be
274274
able to view and participate in the conversation.
275275
{shareDetails}
276-
</p>
277-
<p>{existingCopyNote}</p>
278-
<p>{copyNote}</p>
276+
</div>
277+
<div>{existingCopyNote}</div>
278+
<div>{copyNote}</div>
279279
</>
280280
),
281281
dialogActions: [
@@ -297,13 +297,13 @@ export const ShareRedeem: React.FC = () => {
297297
dialogTitle: inviteTitle,
298298
dialogContent: (
299299
<>
300-
<p>
300+
<div>
301301
You have been <em>invited to observe</em> a conversation: By observing, you will be able to
302302
view the conversation without participating.
303303
{shareDetails}
304-
</p>
305-
<p>{existingCopyNote}</p>
306-
<p>{copyNote}</p>
304+
</div>
305+
<div>{existingCopyNote}</div>
306+
<div>{copyNote}</div>
307307
</>
308308
),
309309
dialogActions: [
@@ -325,12 +325,12 @@ export const ShareRedeem: React.FC = () => {
325325
dialogTitle: inviteTitle,
326326
dialogContent: (
327327
<>
328-
<p>
328+
<div>
329329
You have been <em>invited to copy</em> a conversation:
330330
{shareDetails}
331-
</p>
332-
<p>{existingCopyNote}</p>
333-
<p>{copyNote}</p>
331+
</div>
332+
<div>{existingCopyNote}</div>
333+
<div>{copyNote}</div>
334334
</>
335335
),
336336
dialogActions: [

0 commit comments

Comments
 (0)