Skip to content

Update HTML to remove some HTML5 warnings #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workbench-app/src/components/App/DialogControl.tsx
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ export const DialogControl: React.FC<DialogControlContent> = (props) => {
const classes = useClasses();

return (
<Dialog open={open} defaultOpen={defaultOpen} onOpenChange={onOpenChange}>
<Dialog open={open} defaultOpen={defaultOpen} onOpenChange={onOpenChange} inertTrapFocus={true}>
<DialogTrigger disableButtonEnhancement>{trigger}</DialogTrigger>
<DialogSurface className={classNames?.dialogSurface}>
<DialogBody>
30 changes: 15 additions & 15 deletions workbench-app/src/routes/ShareRedeem.tsx
Original file line number Diff line number Diff line change
@@ -165,7 +165,7 @@ export const ShareRedeem: React.FC = () => {
onClick: () => void;
}) => {
return (
<DialogTrigger disableButtonEnhancement action="open">
<DialogTrigger disableButtonEnhancement action="open" key={options.label}>
<Button
style={{ width: 'max-content' }}
appearance={options?.appearance ?? 'primary'}
@@ -255,11 +255,11 @@ export const ShareRedeem: React.FC = () => {
return renderAppView({
dialogTitle: 'Share is no longer redeemable',
dialogContent: (
<p>
<div>
The share has already been redeemed or has expired.
{shareDetails}
If you believe this is an error, please contact the person who shared the conversation with you.
</p>
</div>
),
});

@@ -269,13 +269,13 @@ export const ShareRedeem: React.FC = () => {
dialogTitle: inviteTitle,
dialogContent: (
<>
<p>
<div>
You have been <em>invited to participate</em> in a conversation: By joining, you will be
able to view and participate in the conversation.
{shareDetails}
</p>
<p>{existingCopyNote}</p>
<p>{copyNote}</p>
</div>
<div>{existingCopyNote}</div>
<div>{copyNote}</div>
</>
),
dialogActions: [
@@ -297,13 +297,13 @@ export const ShareRedeem: React.FC = () => {
dialogTitle: inviteTitle,
dialogContent: (
<>
<p>
<div>
You have been <em>invited to observe</em> a conversation: By observing, you will be able to
view the conversation without participating.
{shareDetails}
</p>
<p>{existingCopyNote}</p>
<p>{copyNote}</p>
</div>
<div>{existingCopyNote}</div>
<div>{copyNote}</div>
</>
),
dialogActions: [
@@ -325,12 +325,12 @@ export const ShareRedeem: React.FC = () => {
dialogTitle: inviteTitle,
dialogContent: (
<>
<p>
<div>
You have been <em>invited to copy</em> a conversation:
{shareDetails}
</p>
<p>{existingCopyNote}</p>
<p>{copyNote}</p>
</div>
<div>{existingCopyNote}</div>
<div>{copyNote}</div>
</>
),
dialogActions: [