Allow comments to be made in files under the commits tree

[simonmichael]

Issue Type: Bug

Enter Review Mode for a pull request. Expand the Commits tree in the sidebar, open a commit, open one of its files, scroll to a diff hunk. Mouse over the + in the right pane's gutter, or the - in the left pane's gutter. When you do this in a file under the Files tree, you can click to create an inline comment. Under the Commits tree, it is not clickable.

This makes it difficult to review by commit.

Extension version: 0.27.1
VS Code version: Code 1.57.1 (Universal) (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin arm64 20.3.0
Restricted Mode: No

System Info

Item	Value
CPUs	Apple M1 (8 x 24)
GPU Status	2d_canvas: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 3, 3
Memory (System)	16.00GB (0.09GB free)
Process Argv	--crash-reporter-id 02db353d-4821-41f7-a6df-92ed86181e77
Screen Reader	no
VM	0%

[ELLIOTTCABLE]

This one is super-important to my workflow. For large, complex PRs, viewing changes "intermingled" is a nightmare — as long as your collaborators are disciplined, it's much easier to view the changes chronologically, which allows you to follow the development of the changes and stay in sync with the author's intentions along the way.

[tizzyapunkt]

Right now, it's at least possible to add comments while viewing the latest commit and to the files this commit touched. Might be coincidence though.

[PeterBenc]

This one together with #3301 is crucial for my workflow, I am kind of sad to see in on deck or in backlog. Not sure how others review PRs but if you can't review by commits they might as well be squashed, not sure why the Commits view exists at all. I am literally waiting for this one feature to migrate from the web UI. 😞

Edit again: I opened the issue for this in February :( :( I came here hoping it got fixed a long time ago.

[ldelossa]

Yeah. This is basically what I'm waiting for to actually use this as a code review tool.

It's pretty good so far, but not being able to review pr's per-commit and comment on them is a major deal breaker for day to day usage.

[PeterBenc]

@alexr00 sorry for the ping, but I suppose not much else I can do at this point, please consider implementing this as I mentioned, "if can't review by commits they might as well be squashed". The notion of commits, is literally one of the core concepts of git/github so honestly I am not sure what has bigger priority 🤔

[PeterBenc]

@alexr00 any comments at least? :) do you see this as low prio or should I keep hoping ?

[ldelossa]

@PeterBenc, maybe its time to fork and implement? I'd take it on with you if you have the time/resources.