This PR shows a different diff than what was merged

[bpasero]

Open: https://github.dev/nodejs/node/pull/54331/files

Click on path.js and notice many changes:

Click on the commit and notice less changes:

Maybe I am doing something wrong but I would have expected the 1 commit to be identical with the entire PR 🤔

[alexr00]

It's because the PR branch has had new commits after the PR was merged: nodejs/node@main...HBSPS:node:path. Should be fixable!

[alexr00]

Thinking about this just a little bit more: this would require that the extension make the diffs in the "Changes" veiw readonly when the PR is merged and the PR branch has advanced. The left side of the diff is correct. The right side of the diff is the file in workspace. We would be changing the right side to instead be a readonly snapshot of the file at the commit that the PR was merged at.

[bpasero]

@alexr00 I guess I was somehow expecting the overall diff view to show me what GH does when you show all file changes of a PR, i.e. the same as https://github.com/nodejs/node/pull/54331/files

But I would not change anything if it impacts our development flow of how we use GH PR for selfhosting, where we also see local changes in the diff.

Maybe a hint or warning or another view in the tree 🤔

[alexr00]

I think your expectation is reasonable. I would only make the right side readonly when the PR is merged.

[bpasero]

💯