preferred_username should be... preferred

TylerLeonhardt · TylerLeonhardt · commit cf1b0ce3d660 · 2023-11-28T12:26:51.000-08:00
Apparently it's possible for preferred_username to be like `foo@mybiz.com` while `email` is set to `foo@mybizemail.com`... This is the more correct ordering.
diff --git a/extensions/microsoft-authentication/src/AADHelper.ts b/extensions/microsoft-authentication/src/AADHelper.ts
@@ -536,7 +536,7 @@ export class AzureActiveDirectoryService {
 			scope: scopeData.scopeStr,
 			sessionId,
 			account: {
-				label: claims.email ?? claims.preferred_username ?? claims.unique_name ?? 'user@example.com',
+				label: claims.preferred_username ?? claims.email ?? claims.unique_name ?? 'user@example.com',
 				id,
 				type: claims.tid === MSA_TID || claims.tid === MSA_PASSTHRU_TID ? MicrosoftAccountType.MSA : MicrosoftAccountType.AAD
 			}

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ export class AzureActiveDirectoryService {`
`536`	`536`	`scope: scopeData.scopeStr,`
`537`	`537`	`sessionId,`
`538`	`538`	`account: {`
`539`		`- label: claims.email ?? claims.preferred_username ?? claims.unique_name ?? 'user@example.com',`
	`539`	`+ label: claims.preferred_username ?? claims.email ?? claims.unique_name ?? 'user@example.com',`
`540`	`540`	`id,`
`541`	`541`	`type: claims.tid === MSA_TID \|\| claims.tid === MSA_PASSTHRU_TID ? MicrosoftAccountType.MSA : MicrosoftAccountType.AAD`
`542`	`542`	`}`