Image stays broken when re-executing Markdown cell

[texttheater]

Applies To

• Notebooks (.ipynb files)
• Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?

1. Create a Markdown cell with an tag referring to a non-existing path, e.g. <img src="myimg.png">.
2. Execute the cell. A "broken image" icon appears.
3. Create the image at the specified path.
4. Click the cell to edit. Re-execute it (without making any changes).

Expected result: the image is now shown.

Actual result: still shows a broken image icon. (The image is only shown after making a change to the cell itself.)

VS Code Version

1.67.2

Jupyter Extension Version

v2022.4.1021342353

Jupyter logs

No response

Coding Language and Runtime Version

Markdown

Language Extension Version (if applicable)

No response

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

Local

[greazer]

Markdown is vscode core.

[danilhendrasr]

Can I take a shot at this?

[IdoHartuv]

I noticed that if we do the opposite action - show the existing image, delete the file and re-execute the cell again when the image file does not exist - the results are the same. The image is still shown like before.
After refreshing the window, or after closing and reopening the .ipynb file tab, the cell is being updated.

Maybe it is related to some cache saved in the cell we can reset each time the cell is being executed.

[Eliiia]

i'd love to try this as my first open source contribution, but i have no clue where to even start looking. if someone can point me to a file or even a directory that is used for the rendering of .ipynb markdown, itd be very appreciated!

[mjbvz]

We have logic to not re-render unchanged markdown cells:

vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts

Line 1036 in 0dfe96e

const sameContent = initialization.content === entry.content;

This is correct if the user presses esc to cancel the current edit. However if they press run / enter, perhaps we need to force a re-render

[danilhendrasr]

Sorry @Eliiia, I know you're looking forward to your first open source contribution, but mind if I take this? Since I proposed to work on it first.