Setting `workbench.panel.opensMaximized` behaves strangely

[bpasero]

I am playing around with workbench.panel.opensMaximized setting. I understand always and never allow me to control how the panel opens when I toggle it.

But preserve does not seem to work properly, steps:

• show editor and panel
• maximise panel
• from the layout controls click to hide panel
• click it again to show panel

=> panel opens restored and not maximised

[benibenj]

This is the reason for this currently:

vscode/src/vs/workbench/browser/layout.ts

Lines 1997 to 2001 in ba15634

	// If maximized and in process of hiding, unmaximize before
	// hiding to allow caching of non-maximized size
	if (hidden && isPanelMaximized) {
	this.toggleMaximizedPanel();
	}

[bpasero]

@benibenj I tried commenting out that code and was not able to get it working, so there is something else.