Add git switch command #114330
Open
Add git switch command #114330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheh
reviewed
Jan 14, 2021
| : localize('select a ref to switch', 'Select a ref to switch')) | ||
| : (opts?.detached | ||
| ? localize('select a ref to checkout detached', 'Select a ref to checkout in detached mode') | ||
| : localize('select a ref to checkout', 'Select a ref to checkout')); |
There was a problem hiding this comment.
nit-pick: There is a fair bit of string repetition here. Suggested resolution:
const action = opts?.command === 'switch' ? 'switch' : 'checkout';
quickpick.placeholder = opts?.detached
? localize(`select a ref to ${action} detached', 'Select a ref to ${action} in detached mode`)
: localize(`select a ref to ${action}', 'Select a ref to ${action}`));
| const force = localize('force', "Force Checkout"); | ||
| const stash = localize('stashcheckout', "Stash & Checkout"); | ||
| const choice = await window.showWarningMessage(localize('local changes', "Your local changes would be overwritten by checkout."), { modal: true }, force, stash); | ||
| const message = opts?.command === 'switch' ? localize('local changes switch', "Your local changes would be overwritten by switch.") : localize('local changes checkout', "Your local changes would be overwritten by checkout."); |
There was a problem hiding this comment.
nit-pick: Same suggestion here:
const action = opts?.command === 'switch' ? 'Switch' : 'Checkout';
const message = localize(`local changes ${action}`, "Your local changes would be overwritten by ${action}.`);
const force = localize(`force${action.toLowerCase()}`, `Force ${action.toLowerCase()}``);
const stash = localize(`stash${action}`, `Stash & ${action}`);
| const choice = await window.showWarningMessage(localize('local changes', "Your local changes would be overwritten by checkout."), { modal: true }, force, stash); | ||
| const message = opts?.command === 'switch' ? localize('local changes switch', "Your local changes would be overwritten by switch.") : localize('local changes checkout', "Your local changes would be overwritten by checkout."); | ||
| const force = opts?.command === 'switch' ? localize('forceswitch', "Force Switch") : localize('forcecheckout', "Force Checkout"); | ||
| const stash = opts?.command === 'switch' ? localize('stashswitch', "Stash & Switch") : localize('stashcheckout', "Stash & Checkout"); |
There was a problem hiding this comment.
nit-pick: The difference use of single and double quotes on the above to line (BTW: I am not sure on what the project coding standard / linting enforces here)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #114066