Fix notebook UI overlap #129286
Open
Fix notebook UI overlap #129286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
commented
Jul 24, 2021
Comment on lines
493
to
+496
| return this.doShowEditor(activeEditor, { active: true, isNew: false /* restored */ }, options).then(() => { | ||
|
|
||
| // Update visibility when restored as the editor start as visible but | ||
| // could be hidden if panel is maximized | ||
| this.onDidVisibilityChange(this.layoutService.isVisible(Parts.EDITOR_PART)); |
There was a problem hiding this comment.
This is needed for the edge case when we have a notebook editor open but with the panel maximized and then reload the window. When the editors are restored they start as visible but are actually hidden as the panel is maximized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #128491 and #128999