handle webview focus on webviewWorkbenchService #139050
Open
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
Mar 17, 2022
| @@ -177,15 +177,15 @@ export class WebviewEditorService extends Disposable implements IWebviewWorkbenc | |||
| this._iconManager = this._register(this._instantiationService.createInstance(WebviewIconManager)); | |||
|
|
|||
| this._register(_editorService.onDidActiveEditorChange(() => { | |||
| this.updateActiveWebview(); | |||
| this.updateActiveWebview(true); | |||
There was a problem hiding this comment.
isFocused == true doesn't make sense to me here. I think the parameter either needs to be renamed or we should fix this another way
| })); | ||
|
|
||
| this.updateActiveWebview(); | ||
| this.updateActiveWebview(true); |
There was a problem hiding this comment.
Also seems incorrect to assume a webview is focused on init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #131289
WebviewService.onDidChangeActiveWebview is fired whenever focus or blur events happen. We can update the active webview when the focus is lost, triggering correct status changes.