Skip to content

Added new config to keep the same line when switching between diffEditors #155395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/vs/editor/common/config/editorConfigurationSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ const editorConfiguration: IConfigurationNode = {
nls.localize('wordWrap.inherit', "Lines will wrap according to the {0} setting.", '`#editor.wordWrap#`'),
]
},
'diffEditor.keepLine': {
type: 'boolean',
default: false,
description: nls.localize('keepLine', "Keep cursor on the same line when focus changes.")
},
'diffEditor.diffAlgorithm': {
type: 'string',
enum: ['smart', 'experimental'],
Expand All @@ -184,7 +189,7 @@ const editorConfiguration: IConfigurationNode = {
nls.localize('diffAlgorithm.smart', "Uses the default diffing algorithm."),
nls.localize('diffAlgorithm.experimental', "Uses an experimental diffing algorithm."),
]
},
}
}
};

Expand Down
60 changes: 45 additions & 15 deletions src/vs/workbench/browser/parts/editor/editorCommands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ import { IEditorResolverService } from 'vs/workbench/services/editor/common/edit
import { IPathService } from 'vs/workbench/services/path/common/pathService';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { extname } from 'vs/base/common/resources';
import { ICodeEditor } from 'vs/editor/browser/editorBrowser';
import { Position } from 'vs/editor/common/core/position';

export const CLOSE_SAVED_EDITORS_COMMAND_ID = 'workbench.action.closeUnmodifiedEditors';
export const CLOSE_EDITORS_IN_GROUP_COMMAND_ID = 'workbench.action.closeEditorsInGroup';
Expand Down Expand Up @@ -382,22 +384,50 @@ function registerDiffEditorCommands(): void {

function focusInDiffEditor(accessor: ServicesAccessor, mode: FocusTextDiffEditorMode): void {
const activeTextDiffEditor = getActiveTextDiffEditor(accessor);
const control = activeTextDiffEditor?.getControl();

if (!control) { return; }
const original = control.getOriginalEditor();
const modified = control.getModifiedEditor();

let source: ICodeEditor | undefined;
let destination: ICodeEditor | undefined;
switch (mode) {
case FocusTextDiffEditorMode.Original:
source = modified;
destination = original;
break;
case FocusTextDiffEditorMode.Modified:
source = original;
destination = modified;
break;
case FocusTextDiffEditorMode.Toggle:
if (modified?.hasWidgetFocus()) {
return focusInDiffEditor(accessor, FocusTextDiffEditorMode.Original);
} else {
return focusInDiffEditor(accessor, FocusTextDiffEditorMode.Modified);
}
}

if (activeTextDiffEditor) {
switch (mode) {
case FocusTextDiffEditorMode.Original:
activeTextDiffEditor.getControl()?.getOriginalEditor().focus();
break;
case FocusTextDiffEditorMode.Modified:
activeTextDiffEditor.getControl()?.getModifiedEditor().focus();
break;
case FocusTextDiffEditorMode.Toggle:
if (activeTextDiffEditor.getControl()?.getModifiedEditor().hasWidgetFocus()) {
return focusInDiffEditor(accessor, FocusTextDiffEditorMode.Original);
} else {
return focusInDiffEditor(accessor, FocusTextDiffEditorMode.Modified);
}
}
if (!destination) { return; }

destination.focus();

const configurationService = accessor.get(IConfigurationService);
const keepLine = configurationService.getValue<boolean>('diffEditor.keepLine');

if (!keepLine || !source) { return; }

const position = source.getPosition();

if (!position) { return; }

const equivalentLineNumber = mode === FocusTextDiffEditorMode.Original ?
control.getDiffLineInformationForModified(position.lineNumber)?.equivalentLineNumber :
control.getDiffLineInformationForOriginal(position.lineNumber)?.equivalentLineNumber;

if (equivalentLineNumber !== undefined) {
destination.setPosition(new Position(equivalentLineNumber, position.column));
}
}

Expand Down