Skip to content

Add support for a border below section headers in Sidebar and Panel #157344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-stewart
Copy link
Contributor

This fixes #157343

Eg:
image

image

It allows for a border to be places below section headers.

In the screenshots above, I have added the border manually in settings.json. This is default to null for all themes since I wasn't sure how it would look with the high contrast themes when I was creating it, but looking at the screenshot above, I think you could make a case for enabling it.

@daviddossett
Copy link
Contributor

Does this only add borders for the bottom of each section header? My impression was that you wanted top and bottom. I also noticed that the sidebar section header border top doesn't get applied to the first/top one.

FWIW I didn't see any impact when adding a value "panelSectionHeader.border".

CleanShot 2022-08-09 at 15 47 20@2x

CleanShot 2022-08-09 at 15 45 48@2x

@daviddossett
Copy link
Contributor

Is this PR still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for a border below section headers in Sidebar and Panel
4 participants