Add tooltips to Window controls #158112
Open
Add tooltips to Window controls #158112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tooltips to Minimize, Maximize, Restore and Close buttons respectively.
`Restore Down` appears to be the terminology used on modern Windows.
sbatten
requested changes
Oct 7, 2022
| @@ -177,7 +179,11 @@ export class TitlebarPart extends BrowserTitleBarPart { | |||
| this.nativeHostService.minimizeWindow(); | |||
| })); | |||
|
|
|||
| // Restore | |||
| this._register(addDisposableListener(minimizeIcon, EventType.MOUSE_OVER, e => { | |||
| setupCustomHover(this.hoverDelegate, minimizeIcon, localize('window.minimize', 'Minimize')); | |||
There was a problem hiding this comment.
The setupCustomHover function is already binding to the DOM event, so you don't need the additional event listener on these. You just need to register the result of the function call.
|
@wmentha are you able to bring this PR up to date and address the comments? |
|
@sbatten Apologies, I'll see if I can address this today 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds
Minimize,Maximize,Restore&Closetooltips to their respective window control button.Demonstration