Add breakpoint context action: Jump To Line

[xiaoyun94]

[roblourens]

Can you tell me more?

[xiaoyun94]

Can you tell me more?

Editor Context Menu Items:

Breakpoint Context Menu Items now:

The reason why add an action into breakpoint context menu is that i installed too many extensions. so threre about 20+ editor context menu actions(shortcut shows my home pc rather than working use)
Editor Conext Menu is easy to be effected by other extensions, but breakpoint Context Menu is limited to be modified.

[roblourens]

I see, I actually wasn't familiar with that command. It probably makes sense to have it where Run to Line appears.

Does this work though? Doesn't it need to do all the other code after gotoTargets that

vscode/src/vs/workbench/contrib/debug/browser/debugCommands.ts

Lines 356 to 369 in 6e539e3

	const targets = response?.body.targets;
	if (targets && targets.length) {
	let id = targets[0].id;
	if (targets.length > 1) {
	const picks = targets.map(t => ({ label: t.label, _id: t.id }));
	const pick = await quickInputService.pick(picks, { placeHolder: nls.localize('chooseLocation', "Choose the specific location") });
	if (!pick) {
	return;
	}
	id = pick._id;
	}
	return await stackFrame.thread.session.goto(stackFrame.thread.threadId, id).catch(e => notificationService.warn(e));

does?

[xiaoyun94]

我明白了，我实际上并不熟悉这个命令。将它放在 Run to Line 出现的地方可能是有意义的。

不过，这行得通吗？在那之后它不需要做所有其他代码吗gotoTargets

vscode/src/vs/workbench/contrib/debug/browser/debugCommands.ts

Lines 356 to 369 in 6e539e3

	const targets = response?.body.targets;
	if (targets && targets.length) {
	let id = targets[0].id;
	if (targets.length > 1) {
	const picks = targets.map(t => ({ label: t.label, _id: t.id }));
	const pick = await quickInputService.pick(picks, { placeHolder: nls.localize('chooseLocation', "Choose the specific location") });
	if (!pick) {
	return;
	}
	id = pick._id;
	}
	return await stackFrame.thread.session.goto(stackFrame.thread.threadId, id).catch(e => notificationService.warn(e));

does?

i have tested in my code server. it works.
Jump to Cursor : may find 2 or more targets due to multi cursors, so it must ask user to choose one.
but Jump to Line here set collom is 0 column at expected line, the cursor is unique, so there is no need to choose.

[roblourens]

I don't think that gotoTargets is expected to have a side effect. If it works, I wonder whether the DA is doing the wrong thing for that request. The description of the request is This request retrieves the possible goto targets for the specified source location.. I will test it next week.

[xiaoyun94]

@roblourens Are you making progress?

[roblourens]

Sorry, it's been a busy time but I will get to it

[roblourens]

Which debugger are you using to test this? I don't see how this can work without calling session.goto, if the DA does the right thing. I think gotoTargets should only retrieve a list of targets.

[xiaoyun94]

Which debugger are you using to test this? I don't see how this can work without calling session.goto, if the DA does the right thing. I think gotoTargets should only retrieve a list of targets.

I use Native Debug as C program Debuger, and it works well @roblourens

[vivodi]

Is this still relevant?