Fix invalid color customization #224272
Closed
Fix invalid color customization #224272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are correct. The color names don't make sense / are swapped. I could trace this back to this commit: 74f5073#diff-e5004af9f54ea471fd25b0c1bebd990b520ab0a32932b8256c0d5739b663b2d2 . Before that commit, there was a single color, called Unfortunately it is too late to fix this mistake now, as this would break countless themes, including the built-in ones: CleanShot.2025-07-15.at.02.23.22.mp4We will have to live with this misnomer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an incorrect setting in "editor.colorcustomization"
This is how the settings for "editorCursor.background" and "editorCursor.foreground" used to work.
"editorCursor.background" became the color of the letter and "editorCursor.foreground" became the background color.
And I changed it to look like this.
