Skip to content

Fix VS Code ignoring --max-old-space-size environment setting for node.js #240616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hackerax1
Copy link

@Hackerax1 Hackerax1 commented Feb 13, 2025

Related to #231076

Add logic to respect --max-old-space-size environment variable in integrated terminal.

  • Modify createTerminalEnvironment function to include --max-old-space-size in the respected set of NODE_OPTIONS.
  • Apply the environment variable collection to the process environment.
  • Restore NODE_OPTIONS for --max-old-space-size if it exists in the parent environment but not in the current environment.

For more details, open the Copilot Workspace session.

…e.js

Related to microsoft#231076

Add logic to respect `--max-old-space-size` environment variable in integrated terminal.

* Modify `createTerminalEnvironment` function to include `--max-old-space-size` in the respected set of `NODE_OPTIONS`.
* Apply the environment variable collection to the process environment.
* Restore `NODE_OPTIONS` for `--max-old-space-size` if it exists in the parent environment but not in the current environment.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/231076?shareId=XXXX-XXXX-XXXX-XXXX).
@Hackerax1
Copy link
Author

@microsoft-github-policy-service agree

@deepak1556 deepak1556 added this to the March 2025 milestone Feb 13, 2025
@deepak1556 deepak1556 removed this from the March 2025 milestone Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants