Bug fix: Accessibility: High contrast theme on activity bar inconsistent #245404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
nickbrit:bug-fix-accessibility |
|
Thank you for the fix! This was a small issue, but inconsistencies add up quick. |
baochit6789
reviewed
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Associated: #245121
Fixed the accessibility hover and active states for activity bar icons in the high contrast theme.
Changes:
::beforewith a new<div>inside the.action-itemcontainer to handle the hover and active outline.::beforedoesn’t work with CSS masks. It is used for outlines, while CSS masks are applied to extension icons, but they don’t work together.<div>ensures the outline is visible and works consistently across all icons.