Skip to content

Bug fix: Accessibility: High contrast theme on activity bar inconsistent #245404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bug fix: Accessibility: High contrast theme on activity bar inconsistent #245404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf95b4
Bug fix: Accessibility: High contrast theme on activity bar inconsistent
nickbrit Apr 3, 2025
52fa23e
Merge branch 'main' into bug-fix-accessibility
nickbrit Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/vs/workbench/browser/parts/activitybar/activitybarPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,18 +584,20 @@ registerThemingParticipant((theme, collector) => {
const outline = theme.getColor(activeContrastBorder);
if (outline) {
collector.addRule(`
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item .action-label::before{
padding: 6px;
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item .action-label-outline{
position: absolute;
inset: 6px;
z-index: 2
}

.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.active .action-label::before,
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.active:hover .action-label::before,
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.checked .action-label::before,
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.checked:hover .action-label::before {
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.active .action-label-outline,
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.active:hover .action-label-outline,
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.checked .action-label-outline,
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.checked:hover .action-label-outline {
outline: 1px solid ${outline};
}

.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item:hover .action-label::before {
.monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item:hover .action-label-outline {
outline: 1px dashed ${outline};
}

Expand Down
3 changes: 3 additions & 0 deletions src/vs/workbench/browser/parts/compositeBarActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,9 @@ export class CompositeBarActionViewItem extends BaseActionViewItem {
// pane composite bar active border + background
append(container, $('.active-item-indicator'));

// outline
append(container, $('.action-label-outline'));

hide(this.badge);

this.update();
Expand Down