fix(editor): handle minimap offset in content width #250315
Open
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
xzakharov
force-pushed
the
fix/content-overlapping
branch
2 times, most recently
from
927d83c to
8592946
Compare
Account for the minimap offset from the viewport edge when calculating the content width, so the minimap does not overlap the content. Closes: microsoft#250072 Signed-off-by: Oleksandr Zakharov <x.zakharov@proton.me>
xzakharov
force-pushed
the
fix/content-overlapping
branch
from
8592946 to
8a488cc
Compare
|
Hi I just tested this PR. I see the following behavior: Screen.Recording.2025-06-12.at.11.31.18.movWhen the minimap is toggled and on the right side, the scrollbar is offset by its width from the right side. The scrollbar should not change position on toggling the minimap on and off. I think this happens because you are changing the contentWidth in your PR. I think there should be another way to do this without changing the content width. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for the minimap offset from the viewport edge when calculating the content width, so the minimap does not overlap the content.
Closes: #250072