Add workbench.action.terminal.sendSignal command #250672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
Tyriar
June 4, 2025 20:21
|
@copilot compile errors: |
…lasses Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
... Fixed all compilation errors by implementing the missing Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
Tyriar
June 5, 2025 10:56
Tyriar
requested changes
Jun 5, 2025
Comment on lines
141
to
149
| const instance = accessor.get(ITerminalService).activeInstance; | ||
| if (instance) { | ||
| const signal = isObject(args) && 'signal' in args ? toOptionalString(args.signal) : undefined; | ||
| if (!signal) { | ||
| return; | ||
| } | ||
| instance.sendSignal(signal); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This should show a quick pick with all possible signals when there is no argument provided.
There was a problem hiding this comment.
Added signal quick pick when no argument is provided. The command now shows a list of 9 common POSIX signals with descriptions when invoked without arguments. See commit 31db9c4.
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
Copilot finished work on behalf of
Tyriar
June 5, 2025 12:35
Tyriar
previously requested changes
Jun 5, 2025
Comment on lines
151
to
161
| const signalOptions: IQuickPickItem[] = [ | ||
| { label: 'SIGINT', description: 'Interrupt process (Ctrl+C)' }, | ||
| { label: 'SIGTERM', description: 'Terminate process gracefully' }, | ||
| { label: 'SIGKILL', description: 'Force kill process' }, | ||
| { label: 'SIGSTOP', description: 'Stop process' }, | ||
| { label: 'SIGCONT', description: 'Continue process' }, | ||
| { label: 'SIGHUP', description: 'Hangup' }, | ||
| { label: 'SIGQUIT', description: 'Quit process' }, | ||
| { label: 'SIGUSR1', description: 'User-defined signal 1' }, | ||
| { label: 'SIGUSR2', description: 'User-defined signal 2' } | ||
| ]; |
There was a problem hiding this comment.
Provide another option after a separator "Manually enter signal" which provides a text input to use.
There was a problem hiding this comment.
Added separator and manual signal input option to the signal picker. When no argument is provided, users can now select from predefined signals or choose "Manually enter signal" to provide a custom signal name. See commit b9db1ff.
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
Tyriar
June 5, 2025 12:51
meganrogge
approved these changes
Jun 5, 2025
Tyriar
approved these changes
Jun 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
workbench.action.terminal.sendSignalcommand that allows sending arbitrary signals to the terminal's foreground process, similar to howworkbench.action.terminal.sendSequenceallows sending arbitrary text sequences.Changes
The implementation follows the exact same pattern as the existing
sendSequencecommand:SendSignaltoTerminalCommandIdenum and registered the action with proper metadataterminalSendSignalCommandfunction that validates signal argument and callsinstance.sendSignal()sendSignalmethod throughout the terminal stack:ITerminalInstanceandTerminalInstanceITerminalProcessManagerandTerminalProcessManagerITerminalChildProcessand implementations (TerminalProcess,ExtHostPseudoterminal)IPtyServiceandPtyServiceSendSignalto remote terminal channel for remote development scenariossendSignalmethodUsage
Users can now create keybindings to send signals:
{ "key": "ctrl+alt+c", "command": "workbench.action.terminal.sendSignal", "args": { "signal": "SIGINT" }, "when": "terminalFocus" }Common signals include:
SIGINT- Interrupt (like Ctrl+C)SIGTERM- Terminate gracefullySIGKILL- Force killSIGSTOP- Stop processSIGCONT- Continue processImplementation Notes
kill(signal)method that supports arbitrary POSIX signalssendSequenceFixes #250671.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
api.github.comnode ./lib/postinstall.js(dns block)http://168.63.129.16:80/machine//usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.