Consolidate ps1 shell integration vars into __VSCodeState #251114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
bug
|
Can you guys give this a try? I've tried on pwsh Mac, and shell integration seem fine. (Tried with starship): This is the difference between the old way (with many variables vieweable when typing 
I think we can ignore PSScriptRoot and PSCommandPath. After I modify shellIntegration.ps1 script, it just seem to point at my script for some reason. |
meganrogge
approved these changes
Jun 10, 2025
|
Just tried on parallels, and I think we are fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #250000
/cc @mattcargile