Misc MCP Auth fixes #251246
Merged
Misc MCP Auth fixes #251246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. only do device code flow if the server supports it 2. fix route in loopback server where error cases were going to `/` which was a typo 3. fix port listening in loopback when default port is taken 4. some servers require registration to have scopes, so passed that through 5. some types clean up
DonJayamanne
approved these changes
Jun 12, 2025
drhurd
added a commit
to drhurd/vscode
that referenced
this pull request
Jun 13, 2025
This reverts commit 6ec42e4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/which was a typo