Skip to content

add partial for terminal selectionMode, set it to be default #251847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2025

Conversation

meganrogge
Copy link
Contributor

fix #243887

demo.mov

@meganrogge meganrogge self-assigned this Jun 18, 2025
@meganrogge meganrogge added this to the June 2025 milestone Jun 18, 2025
@meganrogge meganrogge requested a review from Tyriar June 18, 2025 19:32
@meganrogge
Copy link
Contributor Author

May need to defer this contrast issue. Adding override rules in src/vs/workbench/contrib/terminalContrib/suggest/browser/media/terminalSymbolIcons.css with !important was the only way I got that working so far.

Screenshot 2025-06-18 at 3 44 01 PM

Tyriar
Tyriar previously requested changes Jun 18, 2025
@meganrogge meganrogge merged commit ec89bff into main Jun 18, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/selection-mode-2 branch June 18, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce focused but not selected state to suggest widget
3 participants