feat(core): Nx repo uses ts solution #31654
Open
+20,256
−12,423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=lint,test,build,e2e,e2e-c... |
❌ Failed | 4m 25s | View ↗ |
nx run-many -t check-imports check-commit check... |
✅ Succeeded | 2m 20s | View ↗ |
nx-cloud record -- nx format:check |
✅ Succeeded | 28s | View ↗ |
nx-cloud record -- nx-cloud conformance:check |
✅ Succeeded | 3s | View ↗ |
nx-cloud record -- nx sync:check |
✅ Succeeded | 3s | View ↗ |
nx documentation |
✅ Succeeded | 13s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-07-16 15:57:24 UTC
FrozenPandaz
added
the
priority: medium
ndcunningham
force-pushed
the
feat/ts-solution
branch
from
ec17a51 to
d80a9ab
Compare
ndcunningham
force-pushed
the
feat/ts-solution
branch
from
d80a9ab to
33ffefe
Compare
ndcunningham
force-pushed
the
feat/ts-solution
branch
from
627b3f9 to
398f121
Compare
ndcunningham
force-pushed
the
feat/ts-solution
branch
from
b5ef4c2 to
f58e2a6
Compare
ndcunningham
force-pushed
the
feat/ts-solution
branch
from
063c57b to
7ec46bc
Compare
ndcunningham
force-pushed
the
feat/ts-solution
branch
from
e8d3975 to
7ec46bc
Compare
ndcunningham
force-pushed
the
feat/ts-solution
branch
from
7ec46bc to
555ab52
Compare
…31909) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> This PR adds support for the `proxyConfig` option in the @rspack/dev-server executor, similarly to the existing option in the matching Webpack executor. This new options is another step for allowing simpler migration to Rspack when coming from Webpack, adding to the feature parity of the Rspack executor. ## Current Behavior The `@nx/rspack:dev-server` executor does not allow for passing a `proxyConfig` as an option, opposed to the matching Webpack executor, that does. ## Expected Behavior The `@nx/rspack:dev-server` executor allows for passing a `proxyConfig` option, same as the `@nx/webpack:dev-server` executor. ## Related Issue(s) None.
…ish (#31925) ## Current Behavior When a task with no PTY (e.g. a task using the `nx:noop` executor) has its output pane open and it finishes successfully, no output is shown, and there's a blank space to the right of the task list where the output pane is meant to be. <img width="1366" height="413" alt="image" src="https://github.com/user-attachments/assets/fc34cc18-1bed-4d73-9b94-5a25069e8a3d" /> ## Expected Behavior When a task with no PTY (e.g. a task using the `nx:noop` executor) has its output pane open and it finishes successfully, the output pane should be correctly rendered in a successful status. <img width="1365" height="411" alt="image" src="https://github.com/user-attachments/assets/cb8862d5-f1c2-4aa6-a098-f710020e64f4" />
…ation/enhanced to fix esbuild vulnerability (#31924) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> NX has a dependency to a [vulnerable version of esbuild](GHSA-67mh-4wv8-2f99) Updating several `@module-federation` dependencies to update esbuild to v0.25.5 and fix the vulnerability <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #31923
## Current Behavior The TUI doesn't display live durations for running tasks. <img width="506" height="384" alt="image" src="https://github.com/user-attachments/assets/0c9d2ad6-810c-4785-9e0e-a9e56c86ba7f" /> ## Expected Behavior The TUI should display live durations for running tasks. <img width="499" height="378" alt="image" src="https://github.com/user-attachments/assets/2a675c42-3268-4faf-83d7-f747ad52ce35" /> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> when serve up the react-native app using web configuration, it defaults tsconfig to ``` tsConfig: joinPathFragments(options.projectRoot, 'tsconfig.app.json'), ``` which is not right ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> not hard code ts config path, add a function determineTsConfig for that ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> <!-- This is the behavior we have today --> currently, when options.install=true (need to do pod install), it only syncs deps. <!-- This is the behavior we should expect with the changes in this PR --> make it sync deps regardless of options.install, so when developers choose to run `pod-install` after, it will work right away. <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
…1824) ## Current Behavior Currently, there is no way for a target using `run-commands` to define where in the command args are attached. This is problematic in some tooling cases where args positional location matters ## Expected Behavior Placing `{args}` into the command should allow for interpolation of any and all args provided. Therefore commands can be written such as `docker run {args} imageRef`
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Nx repo to use ts solution to improve build processes and module resolution via the
@nx/js/typescriptplugin.@nx/js/typescript(adding new targetstypecheckandbuild-base)package.jsonfor all dependencies)NODE_PATHhandling in e2e tests.legacy-post-buildexecutor mergingcopy-assetandpackage.jsoncleanup.package.jsonto e2e projects for proper dependency management.