fix(core): ignore type imports in generatePackageJson #31780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adig0
requested review from
FrozenPandaz,
jaysoo,
AgentEnder,
a team and
Coly010
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…-imports-generate-package-json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using generatePackageJson, the resulting package.json includes packages that are only referenced as type-only imports (e.g., import type { X } from 'some-package'). These type-only imports should not appear in the final package.json since they are erased during compilation and not required at runtime.
This leads to unnecessary dependencies being installed in production, which bloats deployments and increases cold start time.
Expected Behavior
generatePackageJson should omit packages that are only used in type-only imports. This ensures the package.json includes only the actual runtime dependencies, avoiding unnecessary installs and potential dependency mismatches.
Related Issue(s)
Fixes #31263