-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-compiletest-directivesArea: compiletest directivesArea: compiletest directivesC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Hmm, that directive is never actually used, and also does not solve the issue for that target. It is a known target, just not one that has
std
(justcore
I assume). None of the directives in the list seem to really capture this? Maybeneeds-threads
is a decent proxy but that's not ideal.
and
Yeah, a proper fix is sth like
//@ needs-std
, but for this PR,//@ ignore-none
is a proxy for ignoring the*-unknown
targets. I suppose//@ ignore-nvptx
is better tho.
Originally posted by @jieyouxu in #141856 (comment)
Metadata
Metadata
Assignees
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-compiletest-directivesArea: compiletest directivesArea: compiletest directivesC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.