ITP JAN 2025 LONDON| ELFREDAH KEVIN-ALERECHI| Module-Structuring-and-Testing-Data | Sprint 3 #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elfredah
changed the title
fearcyf
reviewed
Apr 14, 2025
| @@ -43,14 +43,17 @@ assertEquals(acute, "Acute angle"); | |||
| // When the angle is greater than 90 degrees and less than 180 degrees, | |||
| // Then the function should return "Obtuse angle" | |||
| const obtuse = getAngleType(120); | |||
| // ====> write your test here, and then add a line to pass the test in the function above | |||
| // ====> const obtuse = getAngleType(120); | |||
There was a problem hiding this comment.
shouldn't the test cover angles greater that 90 degrees and and less than 180 degrees?
fearcyf
reviewed
Apr 14, 2025
| // ====> const straight = getAngleType(180); |
There was a problem hiding this comment.
shouldn't the test cover angles greater that 180 degrees and less than 360 degrees.
fearcyf
reviewed
Apr 14, 2025
| @@ -40,14 +40,33 @@ assertEquals(improperFraction, false); | |||
| // target output: true | |||
| // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true. | |||
| const negativeFraction = isProperFraction(-4, 7); | |||
| // ====> complete with your assertion | |||
fearcyf
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Can you add some comment on what this countChar function is doing?
|
There should be more than 4 files that to be modified in this Sprint 3 exercise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.