Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i found some issue with the support of quoted aliases.
CASE 1: multiple quoted alias
Test result: OK
Select Item expected:
Received:
The RegEx
[`].+[`]
match from first backquote to last backquote. The behavior should be from one backquote to the next. Same issue for next case.CASE 2: quoted alias in orderBy
The 'a' alias in this case is:
A A` from z order by `A A
--
I replace the ReqEx with this:
([`])(?:(?=(\\?))\2.)*?\1
And add quoted_identifier as Identifier (not as String) in expr.
The result in orderby:
Hope my fix are correct and helpfull!
Thanks a lot for this library:)!