nlopt: Add support for Python and Octave binding generation

Author: Benjamin Sparks

pkgs/development/libraries/nlopt/default.nix

@@ -3,10 +3,13 @@
   stdenv,
   fetchFromGitHub,
   cmake,
-  octave ? null,
-  libiconv,
+  # Optionally build python bindings
+  withPython ? false,
+  # Optionally build octave bindings
+  withOctave ? false,
+  # For retrieving optional dependencies related to the aforementioned bindings
+  pkgs,
 }:
-
 stdenv.mkDerivation rec {
   pname = "nlopt";
   version = "2.7.1";
@@ -18,26 +21,30 @@ stdenv.mkDerivation rec {
     sha256 = "sha256-TgieCX7yUdTAEblzXY/gCN0r6F9TVDh4RdNDjQdXZ1o=";
   };
 
-  nativeBuildInputs = [ cmake ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ libiconv ];
-  buildInputs = [ octave ];
-
-  configureFlags =
-    [
-      "--with-cxx"
-      "--enable-shared"
-      "--with-pic"
-      "--without-guile"
-      "--without-python"
-      "--without-matlab"
-    ]
-    ++ lib.optionals (octave != null) [
-      "--with-octave"
-      "M_INSTALL_DIR=$(out)/${octave.sitePath}/m"
-      "OCT_INSTALL_DIR=$(out)/${octave.sitePath}/oct"
+  nativeBuildInputs =
+    [ cmake ]
+    ## The octave bindings are vendored within the repository, and therefore do not require further effort.
+    ##
+    ## Building the python bindings requires SWIG, and numpy in addition to the CXX routines.
+    ++ lib.optionals withPython [
+      pkgs.swig
+      (pkgs.python3.withPackages (p: [ p.numpy ]))
     ];
 
+  cmakeFlags = [
+    "-DBUILD_SHARED_LIBS=OFF"
+    "-DNLOPT_CXX=ON"
+    "-DNLOPT_PYTHON=${if withPython then "ON" else "OFF"}"
+    "-DNLOPT_OCTAVE=${if withOctave then "ON" else "OFF"}"
+    "-DNLOPT_MATLAB=OFF"
+    "-DNLOPT_GUILE=OFF"
+    "-DNLOPT_SWIG=${if withPython then "ON" else "OFF"}"
+  ];
+
+  doCheck = true;
+
   postFixup = ''
-    substituteInPlace $out/lib/cmake/nlopt/NLoptLibraryDepends.cmake --replace \
+    substituteInPlace $out/lib/cmake/nlopt/NLoptLibraryDepends.cmake --replace-fail \
       'INTERFACE_INCLUDE_DIRECTORIES "''${_IMPORT_PREFIX}/' 'INTERFACE_INCLUDE_DIRECTORIES "'
   '';
 

pkgs/top-level/all-packages.nix

@@ -4298,7 +4298,7 @@ with pkgs;
 
   nifskope = libsForQt5.callPackage ../tools/graphics/nifskope { };
 
-  nlopt = callPackage ../development/libraries/nlopt { octave = null; };
+  nlopt = callPackage ../development/libraries/nlopt { };
 
   notation = callPackage ../by-name/no/notation/package.nix {
     buildGoModule = buildGo123Module;