Skip to content

Commit feb166e

Browse files
teutat3sljuzig
andcommittedMar 12, 2025
electron: node_module_version should be int
FAILED: gen/third_party/electron_node/config.gypi python3 ../../third_party/electron_node/tools/generate_config_gypi.py gen/third_party/electron_node/config.gypi --out-dir . --dep-file gen/third_party/electron_node/generate_config_gypi.d --node-gn-path //third_party/electron_node Traceback (most recent call last): File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 113, in <module> main() File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 105, in main f.write(repr(translate_config(args.out_dir, config, v8_config))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 62, in translate_config 'node_module_version': int(config['node_module_version']), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid literal for int() with base 10: '"133"' Co-authored-by: Ljuzig <diamond.bertelli@gmail.com>
1 parent 243d892 commit feb166e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎pkgs/development/tools/electron/common.nix

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ in
185185
# build/args/all.gn
186186
is_electron_build = true;
187187
root_extra_deps = [ "//electron" ];
188-
node_module_version = info.modules;
188+
node_module_version = lib.toInt info.modules;
189189
v8_promise_internal_field_count = 1;
190190
v8_embedder_string = "-electron.0";
191191
v8_enable_snapshot_native_code_counters = false;

0 commit comments

Comments
 (0)
Failed to load comments.