angular-language-server: collision with typescript

[xdinterface]

Nixpkgs version

• Stable (24.11)

Describe the bug

I am trying to add the angular-language-server to my packages but it collides with my typescript package.

Steps to reproduce

Add typescript and angular-language-server to your packages and use nixos-rebuild switch to rebuild the system.

Expected behaviour

Both packages should be able to be installed alongside each other.

Screenshots

No response

Relevant log output

error: builder for '/nix/store/qkbvpaz7r4738h46l2nm6lw4jwfmi439-home-manager-path.drv' failed with exit code 2;
       last 2 log lines:
       > warning: different permissions in `/nix/store/gz2hn0l6dz4qbvjdliz5517aan87732x-typescript-5.6.3/lib/node_modules/typescript/ThirdPartyNoticeText.txt' and `/nix/store/16ia3wrrhknxckkh1g9h4y7x4dvg28xj-angular-language-server-19.1.0/lib/node_modules/typescript/ThirdPartyNoticeText.txt': 0444 <-> 0555 at /nix/store/g1yy0f7gq66w9bd5nd9jr2g3jsff9nil-builder.pl line 103.
       > error: collision between `/nix/store/16ia3wrrhknxckkh1g9h4y7x4dvg28xj-angular-language-server-19.1.0/lib/node_modules/typescript/ThirdPartyNoticeText.txt' and `/nix/store/gz2hn0l6dz4qbvjdliz5517aan87732x-typescript-5.6.3/lib/node_modules/typescript/ThirdPartyNoticeText.txt'
       For full logs, run 'nix log /nix/store/qkbvpaz7r4738h46l2nm6lw4jwfmi439-home-manager-path.drv'.
error: 1 dependencies of derivation '/nix/store/yyzflxb3iqp33d72r2z9jkfmkbyai77l-home-manager-generation.drv' failed to build
error: 1 dependencies of derivation '/nix/store/3zrr2zagxfbwipqp0r50xymfp29byr5i-user-environment.drv' failed to build
error: 1 dependencies of derivation '/nix/store/j0k8qgv8dr9q1fsv0l2hgp65q1da4jf1-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/2lgcygfp1g9c3hnr9ymf52c9qddr37f9-nixos-system-framework-24.11.20250302.1546c45.drv' failed to build

Additional context

No response

System metadata

• system: "x86_64-linux"
• host os: Linux 6.13.5, NixOS, 24.11 (Vicuna), 24.11.20250302.1546c45
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.24.12
• channels(root): "nixos-24.05, nixos-unstable"
• nixpkgs: /nix/store/070ny7v4l1lbwx44ac3bsagzwx9mjdcy-source

Notify maintainers

@tricktron

Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

• I assert that this is a bug and not a support request.
• I assert that this is not a duplicate of an existing issue.
• I assert that I have read the NixOS Code of Conduct and agree to abide by it.

Is this issue important to you?

Add a 👍 reaction to issues you find important.

[eclairevoyant]

Typescript isn't the kind of thing that goes in your system packages. Look into https://nix.dev/tutorials/first-steps/declarative-shell per project.

[xdinterface]

Typescript isn't the kind of thing that goes in your system packages. Look into https://nix.dev/tutorials/first-steps/declarative-shell per project.

Nix packages should generally not have the license present at root. It should go in a directory like $out/share/$name/ or similar, to avoid collision.
This has nothing to do with shells.

[tricktron]

@xdinterface Thanks for reporting this. I might need to adapt the file permissions of the node modules in the angular-language-server package.

I'll have a look at this.

[eclairevoyant]

Typescript isn't the kind of thing that goes in your system packages. Look into https://nix.dev/tutorials/first-steps/declarative-shell per project.

Nix packages should generally not have the license present at root.

While that is true, again, typescript doesn't go in one's config. That would avoid this becoming a blocking issue in the first place.

[xdinterface]

Typescript isn't the kind of thing that goes in your system packages. Look into https://nix.dev/tutorials/first-steps/declarative-shell per project.

Nix packages should generally not have the license present at root.

While that is true, again, typescript doesn't go in one's config. That would avoid this becoming a blocking issue in the first place.

I see your point about nix-shells being good practice, but I still think properly packaged Nix modules shouldn't collide regardless of how they're installed.