Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: turbo-unwrapped-2.4.2 #389902

Closed
3 tasks done
brckd opened this issue Mar 14, 2025 · 2 comments · Fixed by #389948
Closed
3 tasks done

Build failure: turbo-unwrapped-2.4.2 #389902

brckd opened this issue Mar 14, 2025 · 2 comments · Fixed by #389948
Labels
0.kind: build failure A package fails to build

Comments

@brckd
Copy link

brckd commented Mar 14, 2025

Nixpkgs version

  • Unstable (25.05)

Steps to reproduce

I attempted to install modrinth-app-0.9.0 in environment.systemPackages, but that relies on Turbo.

Can Hydra reproduce this build failure?

Yes, Hydra can reproduce this build failure.

Link to Hydra build job

https://hydra.nixos.org/build/292260128

Relevant log output

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/v9hkn3r6pmsavp42nzjanj4bdgni7l6b-source
source root is source
Executing cargoSetupPostUnpackHook
Finished cargoSetupPostUnpackHook
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Executing cargoSetupPostPatchHook
Validating consistency between /build/source/Cargo.lock and /build/turbo-unwrapped-2.4.2-vendor/Cargo.lock
Finished cargoSetupPostPatchHook
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing cargoBuildHook
cargoBuildHook flags: -j 16 --target x86_64-unknown-linux-gnu --offline --profile release --package turbo
   Compiling proc-macro2 v1.0.85
   ...
   Compiling globwatch v0.1.0 (/build/source/crates/turborepo-globwatch)
error[E0282]: type annotations needed
   --> crates/turborepo-globwatch/src/lib.rs:217:50
    |
217 | ...                   .extract_if(|p| p.starts_with(flush_dir.as_path()))
    |                                    ^  - type must be known at this point
    |
help: consider giving this closure parameter an explicit type
    |
217 |                                     .extract_if(|p: /* Type */| p.starts_with(flush_dir.as_path()))
    |                                                   ++++++++++++

error[E0061]: this method takes 2 arguments but 1 argument was supplied
   --> crates/turborepo-globwatch/src/lib.rs:217:38
    |
217 | ...                   .extract_if(|p| p.starts_with(flush_dir.as_path()))
    |                        ^^^^^^^^^^---------------------------------------- argument #2 is missing
    |
note: method defined here
   --> /build/rustc-1.85.0-src/library/alloc/src/vec/mod.rs:3700:12
help: provide the argument
    |
217 |                                     .extract_if(|p| p.starts_with(flush_dir.as_path()), /* filter */)
    |                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Compiling turborepo-lockfiles v0.1.0 (/build/source/crates/turborepo-lockfiles)
Some errors have detailed explanations: E0061, E0282.
For more information about an error, try `rustc --explain E0061`.
error: could not compile `globwatch` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

Additional context

No response

System metadata

  • system: "x86_64-linux"
  • host os: Linux 6.12.16, NixOS, 25.05 (Warbler), 25.05.20250224.0196c01
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.24.12
  • nixpkgs: /nix/store/593xvgv994xlkm5mb7w4p1xxnzrs9wv6-source

Notify maintainers

@dlip @getchoo


Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

Is this issue important to you?

Add a 👍 reaction to issues you find important.

@brckd brckd added the 0.kind: build failure A package fails to build label Mar 14, 2025
@getchoo
Copy link
Member

getchoo commented Mar 14, 2025

Thanks for the report!

This was building, but started failing in Hydra during the last staging cycle, so it's probably a Rust 1.85 breakage. Working on a PR now

@getchoo
Copy link
Member

getchoo commented Mar 14, 2025

#389948 should fix this. Feel free to test it out and let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants