Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure: fish #390901

Closed
3 tasks done
toastal opened this issue Mar 18, 2025 · 7 comments · Fixed by #391150
Closed
3 tasks done

Build failure: fish #390901

toastal opened this issue Mar 18, 2025 · 7 comments · Fixed by #391150
Labels
0.kind: build failure A package fails to build

Comments

@toastal
Copy link
Contributor

toastal commented Mar 18, 2025

Nixpkgs version

  • Unstable (25.05)

Steps to reproduce

build fish on aarch64-linux

Can Hydra reproduce this build failure?

Yes, Hydra can reproduce this build failure.

Link to Hydra build job

https://hydra.nixos.org/build/292697277

Relevant log output

> The following tests FAILED:
       >      159 - eval-stack-overflow.py (Failed)
       > Errors while running CTest
       > FAILED: CMakeFiles/fish_run_tests /build/source/build/CMakeFiles/fish_run_tests
       > cd /build/source/build && env FISH_FORCE_COLOR=1 FISH_SOURCE_DIR=/build/source /nix/store/xn9sd8gm81ls18qkgj5qnmfsnqi1p7gm-cmake-3.31.5/bin/ctest --force-new-ctest-process --output-on-failure --progress
       > ninja: build stopped: subcommand failed.

Additional context

No response

System metadata

$ nix run nixpkgs#nix-info -- -m
 - system: `"aarch64-linux"`
 - host os: `Linux 5.4.210-sodp, Sailfish OS, 5.0.0.62 (Tampella), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.25.3`
 - nixpkgs: `/nix/store/mphw46pqiq3x60wq22zna385dw56h2ib-source`

Notify maintainers

@adamcstephens @cole-h @winterqt @SigmaSquadron @r-vdp

Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

Is this issue important to you?

Add a 👍 reaction to issues you find important.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩
@toastal toastal added the 0.kind: build failure A package fails to build label Mar 18, 2025
@SigmaSquadron
Copy link
Contributor

Duplicate of #389377, perhaps?

@toastal
Copy link
Contributor Author

toastal commented Mar 18, 2025

Tests that are failing are different & only happened on aarch64-linux, not x86. 4.0.1 came out recently too.

@adamcstephens
Copy link
Contributor

The tests that have been failing are only affecting aarch64, and appear to be flaky. x86 was only mentioned in the previous issue in reference to binfmt building.

@adamcstephens
Copy link
Contributor

adamcstephens commented Mar 18, 2025 •
edited
Loading

Re-ran and failed on a different test. We’re either going to need to isolate more tests or disable them completely for aarch64-Linux

thread 'tests::string_escape::test_escape_random_var' panicked at src/tests/string_escape.rs:122:9:
assertion `left == right` failed: Escaped and then unescaped string "քΨ\u{c3b}ʆ\u{35c}ाɆ\u{b5a}\u{617}\u{ba0}༐\u{5ae}\u{f37}Β\u{ee3}ڶ\u{efd}\u{36a}\u{b01}˯༌\u{9db}\u{a71}ˉ\u{ade}\u{8ed}ąƆܥލϋต\u{822}୷\u{890}ܐඑࠨ೩౺\u{be1}Ɲ\u{30f}\u{d53}ŁʿЯແ¿uڡۏ\u{e67}\u{bd6}\u{dca}ǚѩЮ༭\u{7b7}༝\u{8c}ƪ\u{f39}֊\u{b91}ਜ਼Ӥਆ\u{90}\u{6e3}ɝ\u{8da}ɦગս\u{a70}ڻஒϸ٦ૹ\u{a04}հϧ੦௪ଞ୰˝\u{cd3}۸Ȉ৴ଈൠ߆؍Μ\u{bbd}ϧ॥*\u{9b3}\u{adb}ѧ\u{a7f}\u{c56}\u{9f}ƅ०பϑ\u{735}\u{8fc}༞؛༎\u{d84}࠲ğ\u{d98}Ұåئষ\u{5fa}\u{b64}എ\u{953}\u{5c8}ॡฌƬฦ\u{bd9}\u{7ae}æ՞तר\u{8f3}߁Ս\u{363}ù\u{7bf}\u{bc5}\u{363}ࣈज़Ռݩ\u{ec7}պ\u{598}\u{329}ಈౚų\u{306}ޔĂےඝ\u{ce5}ɴzঠؿޞʦяϦ\u{cd0}ටก", but got back a different string "քΨ\u{c3b}ʆ\u{35c}ाɆ\u{b5a}\u{617}\u{ba0}༐\u{5ae}\u{f37}Β\u{ee3}ڶ\u{efd}\u{36a}\u{b01}˯༌\u{9db}\u{a71}ˉ\u{ade}\u{8ed}ąƆܥލϋต\u{822}୷\u{890}ܐඑࠨ೩౺\u{be1}Ɲ\u{30f}\u{d53}ŁʿЯແ¿uڡۏ\u{e67}\u{bd6}\u{dca}ǚѩЮ༭\u{7b7}༝\u{8c}ƪ\u{f39}֊\u{b91}ਜ਼Ӥਆ\u{90}\u{6e3}ɝ\u{8da}ɦગս\u{a70}ڻஒϸ٦ૹ\u{a04}հϧ੦௪ଞ୰˝\u{cd3}۸Ȉ৴ଈൠ߆؍Μ\u{bbd}ϧ॥*\u{9b3}\u{adb}ѧ\u{a7f}\u{c56}\u{9f}ƅ०பϑ\u{735}\u{8fc}༞؛༎\u{d84}࠲ğ\u{d98}Ұåئষ\u{5fa}\u{b64}എ\u{953}\u{5c8}ॡฌƬฦ\u{bd9}\u{7ae}æ՞तר\u{8f3}߁Ս\u{363}ù\u{7bf}z". The intermediate escape looked like "_D6_84_CE_A8_E0_B0_BB_CA_86_CD_9C_E0_A4_BE_C9_86_E0_AD_9A_D8_97_E0_AE_A0_E0_BC_90_D6_AE_E0_BC_B7_CE_92_E0_BB_A3_DA_B6_E0_BB_BD_CD_AA_E0_AC_81_CB_AF_E0_BC_8C_E0_A7_9B_E0_A9_B1_CB_89_E0_AB_9E_E0_A3_AD_C4_85_C6_86_DC_A5_DE_8D_CF_8B_E0_B8_95_E0_A0_A2_E0_AD_B7_E0_A2_90_DC_90_E0_B6_91_E0_A0_A8_E0_B3_A9_E0_B1_BA_E0_AF_A1_C6_9D_CC_8F_E0_B5_93_C5_81_CA_BF_D0_AF_E0_BB_81_C2_BF_u_DA_A1_DB_8F_E0_B9_A7_E0_AF_96_E0_B7_8A_C7_9A_D1_A9_D0_AE_E0_BC_AD_DE_B7_E0_BC_9D_C2_8C_C6_AA_E0_BC_B9_D6_8A_E0_AE_91_E0_A9_9B_D3_A4_E0_A8_86_C2_90_DB_A3_C9_9D_E0_A3_9A_C9_A6_E0_AA_97_D5_BD_E0_A9_B0_DA_BB_E0_AE_92_CF_B8_D9_A6_E0_AB_B9_E0_A8_84_D5_B0_CF_A7_E0_A9_A6_E0_AF_AA_E0_AC_9E_E0_AD_B0_CB_9D_E0_B3_93_DB_B8_C8_88_E0_A7_B4_E0_AC_88_E0_B5_A0_DF_86_D8_8D_CE_9C_E0_AE_BD_CF_A7_E0_A5_A5_2A_E0_A6_B3_E0_AB_9B_D1_A7_E0_A9_BF_E0_B1_96_C2_9F_C6_85_E0_A5_A6_E0_AE_AA_CF_91_DC_B5_E0_A3_BC_E0_BC_9E_D8_9B_E0_BC_8E_E0_B6_84_E0_A0_B2_C4_9F_E0_B6_98_D2_B0_C3_A5_D8_A6_E0_A6_B7_D7_BA_E0_AD_A4_E0_B4_8E_E0_A5_93_D7_88_E0_A5_A1_E0_B8_8C_C6_AC_E0_B8_A6_E0_AF_99_DE_AE_C3_A6_D5_9E_E0_A4_A4_D7_A8_E0_A3_B3_DF_81_D5_8D_CD_A3_C3_B9_DE_BF_z".
  left: "քΨ\u{c3b}ʆ\u{35c}ाɆ\u{b5a}\u{617}\u{ba0}༐\u{5ae}\u{f37}Β\u{ee3}ڶ\u{efd}\u{36a}\u{b01}˯༌\u{9db}\u{a71}ˉ\u{ade}\u{8ed}ąƆܥލϋต\u{822}୷\u{890}ܐඑࠨ೩౺\u{be1}Ɲ\u{30f}\u{d53}ŁʿЯແ¿uڡۏ\u{e67}\u{bd6}\u{dca}ǚѩЮ༭\u{7b7}༝\u{8c}ƪ\u{f39}֊\u{b91}ਜ਼Ӥਆ\u{90}\u{6e3}ɝ\u{8da}ɦગս\u{a70}ڻஒϸ٦ૹ\u{a04}հϧ੦௪ଞ୰˝\u{cd3}۸Ȉ৴ଈൠ߆؍Μ\u{bbd}ϧ॥*\u{9b3}\u{adb}ѧ\u{a7f}\u{c56}\u{9f}ƅ०பϑ\u{735}\u{8fc}༞؛༎\u{d84}࠲ğ\u{d98}Ұåئষ\u{5fa}\u{b64}എ\u{953}\u{5c8}ॡฌƬฦ\u{bd9}\u{7ae}æ՞तר\u{8f3}߁Ս\u{363}ù\u{7bf}\u{bc5}\u{363}ࣈज़Ռݩ\u{ec7}պ\u{598}\u{329}ಈౚų\u{306}ޔĂےඝ\u{ce5}ɴzঠؿޞʦяϦ\u{cd0}ටก"
 right: "քΨ\u{c3b}ʆ\u{35c}ाɆ\u{b5a}\u{617}\u{ba0}༐\u{5ae}\u{f37}Β\u{ee3}ڶ\u{efd}\u{36a}\u{b01}˯༌\u{9db}\u{a71}ˉ\u{ade}\u{8ed}ąƆܥލϋต\u{822}୷\u{890}ܐඑࠨ೩౺\u{be1}Ɲ\u{30f}\u{d53}ŁʿЯແ¿uڡۏ\u{e67}\u{bd6}\u{dca}ǚѩЮ༭\u{7b7}༝\u{8c}ƪ\u{f39}֊\u{b91}ਜ਼Ӥਆ\u{90}\u{6e3}ɝ\u{8da}ɦગս\u{a70}ڻஒϸ٦ૹ\u{a04}հϧ੦௪ଞ୰˝\u{cd3}۸Ȉ৴ଈൠ߆؍Μ\u{bbd}ϧ॥*\u{9b3}\u{adb}ѧ\u{a7f}\u{c56}\u{9f}ƅ०பϑ\u{735}\u{8fc}༞؛༎\u{d84}࠲ğ\u{d98}Ұåئষ\u{5fa}\u{b64}എ\u{953}\u{5c8}ॡฌƬฦ\u{bd9}\u{7ae}æ՞तר\u{8f3}߁Ս\u{363}ù\u{7bf}z"


failures:
    tests::string_escape::test_escape_random_url
    tests::string_escape::test_escape_random_var

It would be helpful if a user on aarch64-linux could work through these issues locally and submit a PR. I’ve had no issues personally building on that system and hydra based iteration isn’t something we should strive to do.

@toastal
Copy link
Contributor Author

toastal commented Mar 18, 2025

Would agree, but an underpowered phone isn’t something I can feasibly build on & QEMU is too slow :\

@adamcstephens
Copy link
Contributor

I've run this build a handful of times today on my rpi4 and have yet to reproduce a build failure.

@adamcstephens
Copy link
Contributor

Oh, that link is to the nixos test for fish. The build failure is from https://hydra.nixos.org/build/292778434 and I just re-ran it. I moved to the nix-community aarch64 builder and fish failed to build first time.

@adamcstephens adamcstephens mentioned this issue Mar 19, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: build failure A package fails to build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fish: fix aarch64-linux test failures adamcstephens/nixpkgs
3 participants
@toastal @adamcstephens @SigmaSquadron