-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/keycloak: add realmFiles option #273833
Conversation
8698eec
to
13e3082
Compare
This is a nice feature, could you rebase the PR to resolve the merge conflict? |
09b0b67
to
162639e
Compare
Sorry, I lost track of it. The merge conflict is resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works for me 👍 really usefull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also add a note to the 24.11 release notes about this new feature :) |
5e6c4f2
to
7986289
Compare
Just thought about managing the realm files in /run/keycloak/... via systemd.tmpfiles? so if we remove one from the realmFiles option, it gets removed from the /run-directory too |
For example
|
I tested this but the links also don't get removed during rebuild when using |
7986289
to
181e5d5
Compare
I rebased to resolve conflicts and it uses tmpfiles to link the realm files now. |
Looks nice, I'll give it a try! Would you mind adding a note to the 25.05 release notes? |
181e5d5
to
7f168f0
Compare
Done |
7f168f0
to
9479e34
Compare
Add an option to import Keycloak realms during startup from exported realm files.
9479e34
to
cd10f9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be nice if we could get this merged.
Thank you! |
Description of changes
Enable realm imports during startup as described in the corresponding Keycloak guide.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.