You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
It was brought up on Matrix that ollama is a pretty hefty package and users may want to bring their own variant (e.g. the CUDA variant, or a non-Nix version). This plugin allows configuring the commands, so actual use isn't an issue, but you wouldn't be able to avoid a closure size increase. Maybe we don't want to add ollama to the runtimeDeps? Or maybe there's some way to configure which (if any) version of ollama should be added to runtimeDeps? I know this is possible with "normal" packages but I don't know how easy it is with vim plugins.
It was brought up on Matrix that ollama is a pretty hefty package and users may want to bring their own variant (e.g. the CUDA variant, or a non-Nix version). This plugin allows configuring the commands, so actual use isn't an issue, but you wouldn't be able to avoid a closure size increase. Maybe we don't want to add ollama to the runtimeDeps? Or maybe there's some way to configure which (if any) version of ollama should be added to runtimeDeps? I know this is possible with "normal" packages but I don't know how easy it is with vim plugins.
I agree, we should let user the possibility and responsibility to provide ollama.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
6.topic: vim
8.has: maintainer-list (update)
wegank
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
stale
bot
removed
the
2.status: stale
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.