Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

or-tools: 9.7 -> 9.11 #327509

Merged
merged 4 commits into from
Mar 21, 2025
Merged

or-tools: 9.7 -> 9.11 #327509

merged 4 commits into from
Mar 21, 2025

Conversation

wegank
Copy link
Member

@wegank wegank commented Jul 15, 2024 •
edited
Loading

Description of changes

https://github.com/google/or-tools/releases/tag/v9.11

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 16, 2024
@wegank wegank force-pushed the or-tools-9.9-prep branch from 1943724 to 272966f Compare July 16, 2024 11:03
@wegank wegank changed the title python312Packages.pybind11-{abseil,protobuf}: init or-tools: 9.7 -> 9.9 Jul 16, 2024
@ofborg ofborg bot requested a review from andersk July 16, 2024 11:51
@wegank wegank force-pushed the or-tools-9.9-prep branch from 272966f to 198bba2 Compare July 17, 2024 16:47
@Zoriot
Copy link
Contributor

Zoriot commented Sep 14, 2024

Can you update to v9.11? Also why is that a draft?

@Zoriot Zoriot mentioned this pull request Sep 14, 2024
Open
1 task
@wegank
Copy link
Member Author

wegank commented Sep 19, 2024

Upgrading to 9.10+ is currently impossible in Nixpkgs, as Python support for protobuf 26+ is still broken here.

Another problem with recent or-tools is as follows: or-tools 9.11 requires abseil-cpp 20240722.0, while its dependency pybind11_abseil requires abseil-cpp 20230802.0. So you can imagine that it's simply impossible to build or-tools without massive patches...

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@wegank wegank removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@wegank wegank force-pushed the or-tools-9.9-prep branch from cca99e1 to 4f47882 Compare March 20, 2025 15:45
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2025
@wegank wegank force-pushed the or-tools-9.9-prep branch from 4f47882 to 241506a Compare March 20, 2025 15:47
@wegank wegank force-pushed the or-tools-9.9-prep branch from 241506a to aef59d4 Compare March 21, 2025 08:34
@wegank wegank changed the title or-tools: 9.7 -> 9.9 or-tools: 9.7 -> 9.11 Mar 21, 2025
@wegank wegank marked this pull request as ready for review March 21, 2025 15:20
@nix-owners nix-owners bot requested a review from natsukium March 21, 2025 15:22
@wegank
Copy link
Member Author

wegank commented Mar 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 327509

aarch64-linux

❌ 2 packages failed to build:
  • openroad
  • python313Packages.ortools (python313Packages.ortools.python)
✅ 6 packages built:
  • or-tools
  • or-tools.python (python312Packages.ortools, python312Packages.ortools.python)
  • python312Packages.pybind11-abseil
  • python312Packages.pybind11-protobuf
  • python313Packages.pybind11-abseil
  • python313Packages.pybind11-protobuf

@wegank wegank force-pushed the or-tools-9.9-prep branch from 88d700a to c8f305c Compare March 21, 2025 17:24
@wegank
Copy link
Member Author

wegank commented Mar 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 327509

x86_64-linux

❌ 2 packages failed to build:
  • openroad
  • python313Packages.ortools (python313Packages.ortools.python)
✅ 6 packages built:
  • or-tools
  • or-tools.python (python312Packages.ortools, python312Packages.ortools.python)
  • python312Packages.pybind11-abseil
  • python312Packages.pybind11-protobuf
  • python313Packages.pybind11-abseil
  • python313Packages.pybind11-protobuf

@wegank
Copy link
Member Author

wegank commented Mar 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 327509

aarch64-darwin

❌ 1 package failed to build:
  • python313Packages.ortools (python313Packages.ortools.python)
✅ 6 packages built:
  • or-tools
  • or-tools.python (python312Packages.ortools, python312Packages.ortools.python)
  • python312Packages.pybind11-abseil
  • python312Packages.pybind11-protobuf
  • python313Packages.pybind11-abseil
  • python313Packages.pybind11-protobuf

@wegank wegank merged commit be72260 into NixOS:master Mar 21, 2025
34 of 35 checks passed
@wegank wegank deleted the or-tools-9.9-prep branch March 21, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersk andersk

@natsukium natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @Zoriot