multiviewer-for-f1: add update script #336246
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
Okay so my bad, I misread your lest message on the previous PR. I actually meant that you should have one commit for the version bump and one commit for the script inside one single PR. I should've been clearer with that too It doesn't matter though, this works as well! Anyways, this looks good to me, I don't have access to my NixOS desktop right now to test it but I don't see anything wrong |
|
I also figured unless the package is currently broken, the script can do the bump the next time the repo-wide update is triggered. |
|
Also I think you might have to change the PR name to something like |
wegank
added
the
12.approvals: 1
bglebrun
changed the title
Fixed |
wegank
added
12.approvals: 2
| link=$(echo $latest | jq -r '.downloads[] | select(.platform=="linux_deb").url') | ||
| id=$(echo $latest | jq -r '.downloads[] | select(.platform=="linux_deb").id') | ||
| version=$(echo $latest | jq -r '.version') | ||
|
|
There was a problem hiding this comment.
I think it would be good to skip the download if the version is already packaged. No need to wastefully download ~150MB.
There was a problem hiding this comment.
Fixed, thanks for the tip!
FliegendeWurst
added
the
2.status: merge conflict
Checks if the version pulled from our metadata API is the same as the current version, preventing a pull of the package if an update is not necessary.
wegank
removed
the
12.approvals: 2
|
Please fix the merge conflict. |
wegank
added
the
12.approvals: 3+
…n/nixpkgs into multiviewer-for-f1-update-script
| link=$(echo $latest | jq -r '.downloads[] | select(.platform=="linux_deb").url') | ||
| id=$(echo $latest | jq -r '.downloads[] | select(.platform=="linux_deb").id') | ||
| version=$(echo $latest | jq -r '.version') | ||
|
|
There was a problem hiding this comment.
Fixed, thanks for the tip!
ofborg
bot
removed
the
2.status: merge conflict
wegank
removed
the
12.approvals: 3+
|
Why this is stucked and outdated? The multiview app is currently in v1.42.1 |
|
I've been waiting, as far as I know everything is taken care of. Would probably be faster to open a pull request for an update. |
|
Merge this before my PR will break my PR I think. #391691 |
Description of changes
Add update script to multiviewer-for-f1 derivation
Possibly closes #336005
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.