-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binary-ninja: init at 4.2.6455 #360314
binary-ninja: init at 4.2.6455 #360314
Conversation
136f208
to
cfc994e
Compare
@ofborg build binary-ninja |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4898 |
This doesn't work under wayland:
By the way, there has been another PR to add the free version of binary ninja: #322496 (wayland works in this one), which uses autoPatchelfHook. Also, shouldn't this be named |
733f525
to
900cdc5
Compare
I agree with the suggestions re: attribute name. Took major inspiration from #322496 but fixed it up and made the closure smaller with (as far as I can tell) no runtime issues. |
900cdc5
to
9f29f3d
Compare
Added icon, thanks very much for the example |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works under wayland and xwayland. The debugger also appears to work.
@eilvelia @SuperSandro2000 what can we do to get this approved and merged? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5291 |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.