Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cns11643-kai: init at 0-unstable-2025-01-13 #363429

Merged
merged 2 commits into from
Mar 22, 2025

Conversation

rypervenche
Copy link
Contributor

This is a new package for a Chinese font created by the Taiwan Ministry of Education. It contains 108,906 characters, including both simplified and traditional variants. It is the Standard script (a.k.a. "Kai"), which is the most common script used in modern printed materials.

A link to the government website that contains the link to the font can be found at the bottom of:
https://www.cns11643.gov.tw/pageView.jsp?ID=59

which leads to the government website:
https://data.gov.tw/dataset/5961 (It's the second ZIP button)

Note: as the download link is hosted on a government site in Taiwan, it's quite slow, but it does eventually download.

This is my first package submission, so if anything needs to be changed, please let me know. I'm happy to be a maintainer for this package and all future packages that I plan to submit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rypervenche rypervenche force-pushed the cns11643-kai branch 2 times, most recently from d32c218 to a21bf4c Compare December 9, 2024 01:31
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 10, 2024
Comment on lines 11 to 16
src = fetchzip {
url = "https://www.cns11643.gov.tw/opendata/Fonts_Kai.zip";
hash = "sha256-zKFzqCbf41hbg3G6ShGJTsA8YgsTbw3SHEETn476LZA=";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this source zip changed since you packaged the font.

trying https://www.cns11643.gov.tw/opendata/Fonts_Kai.zip
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       > 100 54.3M  100 54.3M    0     0   185k      0  0:04:59  0:04:59 --:--:--  212k
       > unpacking source archive /build/Fonts_Kai.zip
       > error: zip file must contain a single file or directory.
       > hint: Pass stripRoot=false; to fetchzip to assume flat list of files.

I would suggest to use an archived version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the upstream does not have semantic releases and overwrites each font with the new release. I took a look at how Arch is doing it in their AUR package and they created a repository to store the fonts, however it hasn't been updated in a while.

I went ahead and created a GitHub repository to hold the font, as well as a little update script that I'll automate in the near future so I'll know when a new release comes out for the font. I've updated the package.nix file and squashed the changes.

Please let me know if anything else needs to be changed. Thanks!

@FliegendeWurst FliegendeWurst marked this pull request as draft March 6, 2025 16:40
@rypervenche rypervenche changed the title cns11643-kai: init at 0-unstable-2024-09-13 cns11643-kai: init at 0-unstable-2025-01-13 Mar 20, 2025
@FliegendeWurst FliegendeWurst marked this pull request as ready for review March 22, 2025 22:11
@FliegendeWurst FliegendeWurst merged commit 2c3dbb1 into NixOS:master Mar 22, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants