-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cns11643-kai: init at 0-unstable-2025-01-13 #363429
Conversation
d32c218
to
a21bf4c
Compare
src = fetchzip { | ||
url = "https://www.cns11643.gov.tw/opendata/Fonts_Kai.zip"; | ||
hash = "sha256-zKFzqCbf41hbg3G6ShGJTsA8YgsTbw3SHEETn476LZA="; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this source zip changed since you packaged the font.
trying https://www.cns11643.gov.tw/opendata/Fonts_Kai.zip
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 54.3M 100 54.3M 0 0 185k 0 0:04:59 0:04:59 --:--:-- 212k
> unpacking source archive /build/Fonts_Kai.zip
> error: zip file must contain a single file or directory.
> hint: Pass stripRoot=false; to fetchzip to assume flat list of files.
I would suggest to use an archived version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the upstream does not have semantic releases and overwrites each font with the new release. I took a look at how Arch is doing it in their AUR package and they created a repository to store the fonts, however it hasn't been updated in a while.
I went ahead and created a GitHub repository to hold the font, as well as a little update script that I'll automate in the near future so I'll know when a new release comes out for the font. I've updated the package.nix file and squashed the changes.
Please let me know if anything else needs to be changed. Thanks!
a21bf4c
to
32ba560
Compare
32ba560
to
ccbe445
Compare
ccbe445
to
53249b4
Compare
This is a new package for a Chinese font created by the Taiwan Ministry of Education. It contains 108,906 characters, including both simplified and traditional variants. It is the Standard script (a.k.a. "Kai"), which is the most common script used in modern printed materials.
A link to the government website that contains the link to the font can be found at the bottom of:
https://www.cns11643.gov.tw/pageView.jsp?ID=59
which leads to the government website:
https://data.gov.tw/dataset/5961 (It's the second ZIP button)
Note: as the download link is hosted on a government site in Taiwan, it's quite slow, but it does eventually download.
This is my first package submission, so if anything needs to be changed, please let me know. I'm happy to be a maintainer for this package and all future packages that I plan to submit.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.