Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/shairport-sync: add freeform config #363739

Merged
merged 2 commits into from
Mar 22, 2025
Merged

nixos/shairport-sync: add freeform config #363739

merged 2 commits into from
Mar 22, 2025

Conversation

jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Dec 9, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 9, 2024
@jopejoe1 jopejoe1 force-pushed the shairport-sync-conf branch from 7837a25 to 49c9a39 Compare December 9, 2024 22:09
devusb
devusb approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@devusb devusb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested -- worked well to set configuration options.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 20, 2025
@jopejoe1 jopejoe1 force-pushed the shairport-sync-conf branch from 49c9a39 to 8e35736 Compare March 15, 2025 20:06
@jopejoe1 jopejoe1 force-pushed the shairport-sync-conf branch from 8e35736 to c38c901 Compare March 15, 2025 20:07
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 16, 2025
@jopejoe1 jopejoe1 merged commit e267d07 into NixOS:master Mar 22, 2025
28 checks passed
@jopejoe1 jopejoe1 deleted the shairport-sync-conf branch March 22, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@GaetanLepage GaetanLepage

@devusb devusb

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jopejoe1 @devusb @SuperSandro2000 @GaetanLepage @wegank