Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chafa: support avif, jxl and svg image formats; add zsh completion; split outputs #369630

Merged
merged 3 commits into from
Mar 23, 2025

Conversation

folliehiyuki
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The new package can be verified by running:

$ ./result-bin/bin/chafa --version
Chafa version 1.14.5

Loaders:  AVIF GIF JPEG JXL PNG QOI SVG TIFF WebP XWD
Features: mmx sse4.1 popcnt avx2
Applying: mmx sse4.1 popcnt avx2

Copyright (C) 2018-2024 Hans Petter Jansson et al.
Incl. libnsgif copyright (C) 2004 Richard Wilson, copyright (C) 2008 Sean Fox
Incl. LodePNG copyright (C) 2005-2018 Lode Vandevenne
Incl. QOI decoder copyright (C) 2021 Dominic Szablewski

This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Add a 👍 reaction to pull requests you find important.

@folliehiyuki folliehiyuki force-pushed the chafa-svg branch 3 times, most recently from 2610964 to 5bf7ccd Compare March 22, 2025 06:01
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Mar 22, 2025
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Mar 22, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 369630

Logs: https://github.com/GaetanLepage/nixpkgs-review-gha/actions/runs/14020647681


x86_64-linux

✅ 11 packages built:
  • chafa
  • chafa.bin
  • chafa.dev
  • chafa.man
  • ctpv
  • fastfetch
  • fastfetch.man
  • kew
  • ueberzugpp
  • yazi
  • ytfzf

aarch64-linux

✅ 11 packages built:
  • chafa
  • chafa.bin
  • chafa.dev
  • chafa.man
  • ctpv
  • fastfetch
  • fastfetch.man
  • kew
  • ueberzugpp
  • yazi
  • ytfzf

x86_64-darwin

✅ 10 packages built:
  • chafa
  • chafa.bin
  • chafa.dev
  • chafa.man
  • fastfetch
  • fastfetch.man
  • kew
  • ueberzugpp
  • yazi
  • ytfzf

aarch64-darwin

✅ 10 packages built:
  • chafa
  • chafa.bin
  • chafa.dev
  • chafa.man
  • fastfetch
  • fastfetch.man
  • kew
  • ueberzugpp
  • yazi
  • ytfzf

@GaetanLepage GaetanLepage merged commit 3f263d1 into NixOS:master Mar 23, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants