Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyside6-qtads: init at 4.3.1.1 #370105

Merged
merged 4 commits into from
Mar 22, 2025

Conversation

spencerpogo
Copy link
Contributor

Add the python library pyside6-qtads, pyside6 bindings for the Qt Advanced Docking System, and it build dependency. Motivation: pyside6-qtads is a dependency of angr-management and this PR is a spinoff from #360310.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

src = fetchFromGitHub {
owner = "diegoferigo";
repo = "cmake-build-extension";
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tag

src = fetchFromGitHub {
owner = "mborgerson";
repo = "pyside6_qtads";
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag


meta = {
description = "Python bindings to Qt Advanced Docking System for PySide6";
homepage = "https://github.com/mborgerson/pyside6_qtads";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog

@fabaff fabaff dismissed ethancedwards8’s stale review March 22, 2025 20:27

Comments addressed.

@fabaff
Copy link
Member

fabaff commented Mar 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370105


x86_64-linux

✅ 8 packages built:
  • python312Packages.cmake-build-extension
  • python312Packages.cmake-build-extension.dist
  • python312Packages.pyside6-qtads
  • python312Packages.pyside6-qtads.dist
  • python313Packages.cmake-build-extension
  • python313Packages.cmake-build-extension.dist
  • python313Packages.pyside6-qtads
  • python313Packages.pyside6-qtads.dist

@fabaff fabaff merged commit d1c3337 into NixOS:master Mar 22, 2025
23 of 27 checks passed
@spencerpogo spencerpogo deleted the pyside6-qtads branch March 23, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants