expressvpn: fix daemon not able to modify resolv.conf #379943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
NixOSInfra
added
the
12. first-time contribution
FliegendeWurst
changed the title
FliegendeWurst
approved these changes
Mar 13, 2025
naminx
added a commit
to naminx/nixpkgs
that referenced
this pull request
Mar 25, 2025
My original method exposes the whole /etc directory to FHS environment. This is risky considering the service is run as root. In pull request NixOS#379943, the author uses mount --bind to expose only etc/resolv.conf to the FHS. This is obviously a better practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
The expressvpnd binary is unable to modify the host's DNS configuration from FHS sandbox.
These changes mount the host's resolv.conf into the container to fix the issue.
Relevant issue: #210439
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.