python3Packages.pyquerylist: init at 0-unstable-2025-03-03 #382170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
112b158 to
6911f1b
Compare
ethancedwards8
suggested changes
Feb 15, 2025
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
6911f1b to
7234263
Compare
ethancedwards8
approved these changes
Feb 15, 2025
pyrox0
requested changes
Feb 15, 2025
|
original tests use nose (1), which doesn't exist in nixpkgs, currently rewriting them in pytest |
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
7234263 to
8686cfe
Compare
|
One set of tests still remainig |
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
8686cfe to
81cfa76
Compare
|
Unit tests in place and working, doctests have to be run as a separate pytest command so the hook ommits them. |
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
2 times, most recently
from
ddfffa4 to
8bd95d3
Compare
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
8bd95d3 to
d69400e
Compare
philipwilk
changed the title
|
Patches have been merged upstream, ready to merge now. |
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
d69400e to
59c649f
Compare
getchoo
reviewed
Mar 15, 2025
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
59c649f to
143a670
Compare
philipwilk
force-pushed
the
python3Packages.pyquerylist
branch
from
143a670 to
218abf6
Compare
getchoo
approved these changes
Mar 15, 2025
getchoo
added
the
12.approvals: 1
wegank
added
12.approvals: 2
|
pyrox0
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init pyquerylist, using commit as rev as there a (relatively) recent changes that are not in a release.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.