virglrenderer: enable venus and DRM native context support #382283
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only Venus has been (superficially, but successfully) tested. Native context is untested because I didn't want to hunt down appropriately patched QEMU and Mesa versions. |
I do happen to have such a setup lying around (https://codeberg.org/kuruczgy/aarch64-gaming/commit/8e50a5d7fd17dc9ae083f5b59cd5f02a882a969e1d86e6f92dd81891cb23c487), so I tested it, drm native context seems to work well with this PR 👍 (system: aarch64, Snapdragon X Elite)
|
|
13 tasks
scarlet-storm
approved these changes
Mar 13, 2025
wegank
added
the
12.approvals: 1
|
NyCodeGHG
approved these changes
Mar 17, 2025
wegank
added
12.approvals: 2
PedroHLC
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
Testing VM:
{ nixpkgs
, testingDM ? "gdm" # "sddm" | "gdm"
, testingDE ? "gnome" # "plasma6" | "gnome"
, testingSession ? "gnome" # "gnome" | "plasma"
, testingWithAutoLogin ? true
}:
import "${nixpkgs}/nixos/tests/make-test-python.nix" ({ pkgs, lib, ... }: {
name = "venus-test";
nodes.machine = { pkgs, ... }: {
imports = [
"${nixpkgs}/nixos/tests/common/user-account.nix"
];
virtualisation.qemu.options = [
"-m 16G"
"-vga none"
"-device virtio-vga-gl,hostmem=8G,blob=true,venus=true"
"-object memory-backend-memfd,id=mem1,size=16G"
"-machine memory-backend=mem1"
"-display gtk,gl=on"
];
# Apply nixpkgs#382283
virtualisation.qemu.package = lib.mkForce (pkgs.qemu.override {
virglrenderer = pkgs.virglrenderer.overrideAttrs (prevAttrs: {
buildInputs = prevAttrs.buildInputs ++ [ pkgs.vulkan-headers pkgs.vulkan-loader ];
mesonFlags = prevAttrs.mesonFlags ++ [ (lib.mesonBool "venus" true) (lib.mesonOption "drm-renderers" "amdgpu-experimental,msm") ];
});
});
environment.systemPackages = with pkgs; [
vulkan-tools
mesa-demos
alacritty
];
services.xserver = {
enable = true;
displayManager = {
"${testingDM}".enable = true;
autoLogin = {
enable = testingWithAutoLogin;
user = "alice";
};
defaultSession = testingSession;
};
desktopManager.${testingDE}.enable = true;
};
};
# TODO: TODO
testScript =
''
start_all()
'';
})Venus is currently required for Vulkan support in Virtio-GPU. DRM native context will allow using the native Mesa drivers in the guest, improving support and performance; support in QEMU (on the host) and Mesa (on the guest) is required and not in upstream releases yet. Fixes: NixOS#379454
alois31
force-pushed
the
push-ztonpmwqkkwu
branch
from
0becbf9 to
d082fd7
Compare
wegank
removed
the
12.approvals: 2
scarlet-storm
approved these changes
Mar 21, 2025
eljamm
added
the
12.approvals: 1
wegank
added
12.approvals: 3+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Venus is currently required for Vulkan support in Virtio-GPU. DRM native context will allow using the native Mesa drivers in the guest, improving support and performance; support in QEMU (on the host) and Mesa (on the guest) is required and not in upstream releases yet.
Fixes: #379454
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.