Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/steam: allow overriding args passed to Steam in session #382376

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

pks-t
Copy link
Contributor

@pks-t pks-t commented Feb 15, 2025

The Gamescope session executes Steam with a fixed set of arguments, enabling its tenfoot interface. In some cases though one may want to override these arguments, e.g. by using big picture more instead or enabling SteamOS integration.

Introduce a new option that allows to override these arguments.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The Gamescope session executes Steam with a fixed set of arguments,
enabling its tenfoot interface. In some cases though one may want to
override these arguments, e.g. by using big picture more instead or
enabling SteamOS integration.

Introduce a new option that allows to override these arguments.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 15, 2025
@pks-t pks-t requested review from K900, mkg20001 and Atemu February 15, 2025 18:04
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 15, 2025
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 17, 2025
@pks-t
Copy link
Contributor Author

pks-t commented Mar 24, 2025

@K900 @mkg20001 Thanks for your reviews! Can I do anything to help get this PR merged? 🙏

@K900 K900 merged commit f470616 into NixOS:master Mar 24, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants