Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: remove optional jmol dep (and thus also jre8) #382929

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

amarshall
Copy link
Member

@amarshall amarshall commented Feb 17, 2025

We are now past Sage 10.5, and jmol is now optional so unneeded in the default env.

See sagemath/sage#31027

Things done

Tested basic CLI usage.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 4 packages built:
  • cantor
  • labplot
  • sage
  • sageWithDoc

Add a 👍 reaction to pull requests you find important.

We are now past Sage 10.5, and jmol is now optional so unneeded in the
default env.

See sagemath/sage#31027
@collares
Copy link
Member

I'd say this is a good change, but honestly I don't use 3D plots in Sage. Still, I think the best course of action is to merge this and wait to see if someone misses the functionality provided by Jmol.

@collares collares merged commit 058b086 into NixOS:master Mar 18, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants